[full-ci] Show sharees as avatars #5758

lookacat · 2021-08-31T13:39:43Z

Description

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

update-docs · 2021-08-31T13:39:46Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

ownclouders · 2021-08-31T15:13:30Z

Results for oC10iPhoneNotifications https://drone.owncloud.com/owncloud/web/18746/44/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-09-01T14:57:56Z

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18768/24/1
The following scenarios passed on retry:

webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104

ownclouders · 2021-09-01T15:01:42Z

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/18768/65/1
The following scenarios passed on retry:

webUIDeleteFilesFolders/deleteFilesFolders.feature:59

ownclouders · 2021-09-01T15:10:51Z

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18768/40/1
The following scenarios passed on retry:

webUISharingExternalToRoot/federationSharing.feature:356

pascalwengerter · 2021-09-02T19:19:41Z

@paulcod3 I changed the merge target branch, please rebase on #5770 (motivation for this is outlined there). You can then use the ODS 10.0.0, including the new avatars-component

Also, please squash on merge 😉

pascalwengerter · 2021-09-03T14:30:42Z

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue

        >
-          <li v-for="collaborator in collaborators" :key="collaborator.key">
+          <h2 class="shared-with-label" v-text="sharedWithLabel" />
+          <oc-avatars


No clue how the CI got that green if you're referencing a component the current version of ODS doesn't even know about 🤔

oh that is true lol

kulmann

I'm afraid there's some stuff that doesn't work with this solution, sorry.

the click handler on the div only works for mouse users. that's not accessible and not keyboard power user compatible.
there is no way of closing the people list again
I'd expect the avatars to be invisible when the list is expanded

I think for accessibility reasons the OcAvatars component needs to have a type prop to distinguish if it's a presentational element or an interactive element. If it's interactive it needs to be an oc-button with appearance="raw" so that it's focusable and usable with both keyboard and mouse. Needs another PR in ODS, sorry :-(

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue

kulmann · 2021-09-06T12:25:28Z

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue

+    collaborators_avatar() {
+      const result = []
+      console.log(this.collaborators)
+      this.collaborators.forEach(c => result.push({ ...c.collaborator, shareType: c.shareType }))


Instead of building a result in a const, you can just

return this.collaborators.map(c => { ...c.collaborator, shareType: c.shareType })

nope the '...' doesnt work on map

Why? The following works fine:

collaborators_avatar() { return this.collaborators.map(c => { return { ...c.collaborator, shareType: c.shareType } }) },

Why is the computed prop name in snake case by the way? 🤔

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue

packages/web-runtime/package.json

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue

…roup

ownclouders · 2021-09-07T08:03:25Z

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18909/40/1
The following scenarios passed on retry:

webUISharingExternalToRoot/federationSharing.feature:356

ownclouders · 2021-09-07T08:11:40Z

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18909/12/1
The following scenarios passed on retry:

webUIFilesActionMenu/versions.feature:36

…cloud/web into show-sharees-as-avatar-group

kulmann

Nice! 🚀

pascalwengerter · 2021-09-07T10:17:59Z

Please squash on merge 😬

ownclouders · 2021-09-07T10:35:26Z

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18919/34/1
The following scenarios passed on retry:

webUISharingPublicManagement/publicLinkIndicator.feature:27

sonarqubecloud · 2021-09-07T10:42:15Z

Please retry analysis of this Pull-Request directly on SonarCloud.

* WIP * WIP * fixed styling * fixed open people panel * fixed linting * changed to RC ODS version * hide shredwith label when no sharees * remove dev leftover * refactored raw button around ocavatars * added closing mechanism * removed copy pasta id * addressed PR issues * fixed PR issues * fixed tooltip, alignment * fixed PR issues * removed aria-hidden * fixed alignment

WIP

cbd54fe

lookacat mentioned this pull request Aug 31, 2021

Refactor OcAvatarGroup into OcAvatars owncloud/owncloud-design-system#1614

Merged

10 tasks

lookacat force-pushed the show-sharees-as-avatar-group branch from 29ed1da to 2444c2a Compare August 31, 2021 14:42

WIP

679b2ca

lookacat force-pushed the show-sharees-as-avatar-group branch from 2444c2a to 679b2ca Compare August 31, 2021 15:01

lookacat changed the title ~~Show sharees as avatars~~ [full-ci] Show sharees as avatars Sep 1, 2021

fixed styling

2e90b87

lookacat force-pushed the show-sharees-as-avatar-group branch from 89a1fa6 to 2e90b87 Compare September 1, 2021 14:33

lookacat added 3 commits September 2, 2021 14:08

Merge branch 'master' into show-sharees-as-avatar-group

a3d26a7

fixed open people panel

c83bfc4

fixed linting

446eaa1

pascalwengerter changed the base branch from master to 02092021_bump-ods-10.0.0 September 2, 2021 19:18

pascalwengerter force-pushed the 02092021_bump-ods-10.0.0 branch from bc62c4f to e90131c Compare September 3, 2021 10:24

pascalwengerter reviewed Sep 3, 2021

View reviewed changes

lookacat added 2 commits September 6, 2021 09:25

changed to RC ODS version

d3214d4

Merge branch 'master' into show-sharees-as-avatar-group

476e55c

lookacat force-pushed the 02092021_bump-ods-10.0.0 branch from e90131c to 144706c Compare September 6, 2021 07:38

lookacat marked this pull request as ready for review September 6, 2021 08:17

lookacat requested review from fschade and kulmann as code owners September 6, 2021 08:17

lookacat requested a review from pascalwengerter September 6, 2021 08:17

hide shredwith label when no sharees

f2f8587

kulmann suggested changes Sep 6, 2021

View reviewed changes

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue Outdated Show resolved Hide resolved

remove dev leftover

dc440b3

lookacat added 3 commits September 6, 2021 14:07

refactored raw button around ocavatars

ea82d90

added closing mechanism

19fad05

removed copy pasta id

787124c

kulmann suggested changes Sep 6, 2021

View reviewed changes

addressed PR issues

a046251

lookacat requested a review from kulmann September 6, 2021 13:17

kulmann suggested changes Sep 6, 2021

View reviewed changes

packages/web-runtime/package.json Outdated Show resolved Hide resolved

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue Outdated Show resolved Hide resolved

lookacat added 2 commits September 7, 2021 09:24

fixed PR issues

ca95441

Merge branch '02092021_bump-ods-10.0.0' into show-sharees-as-avatar-g…

51ec2ce

…roup

lookacat requested a review from kulmann September 7, 2021 07:27

lookacat added 3 commits September 7, 2021 12:00

fixed tooltip, alignment

98e5ec6

Merge branch 'show-sharees-as-avatar-group' of https://github.com/own…

160fc69

…cloud/web into show-sharees-as-avatar-group

fixed PR issues

3a529ab

lookacat force-pushed the show-sharees-as-avatar-group branch from aaa1231 to 3a529ab Compare September 7, 2021 10:08

kulmann approved these changes Sep 7, 2021

View reviewed changes

removed aria-hidden

9b96c9c

fixed alignment

38aab1a

lookacat merged commit 7dbbc0c into 02092021_bump-ods-10.0.0 Sep 7, 2021

delete-merged-branch bot deleted the show-sharees-as-avatar-group branch September 7, 2021 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] Show sharees as avatars #5758

[full-ci] Show sharees as avatars #5758

lookacat commented Aug 31, 2021 •

edited

Loading

update-docs bot commented Aug 31, 2021

ownclouders commented Aug 31, 2021

ownclouders commented Sep 1, 2021

ownclouders commented Sep 1, 2021

ownclouders commented Sep 1, 2021

pascalwengerter commented Sep 2, 2021 •

edited

Loading

pascalwengerter Sep 3, 2021

lookacat Sep 6, 2021

kulmann left a comment

kulmann Sep 6, 2021

lookacat Sep 6, 2021

kulmann Sep 7, 2021

ownclouders commented Sep 7, 2021

ownclouders commented Sep 7, 2021

kulmann left a comment

pascalwengerter commented Sep 7, 2021

ownclouders commented Sep 7, 2021

sonarqubecloud bot commented Sep 7, 2021

[full-ci] Show sharees as avatars #5758

[full-ci] Show sharees as avatars #5758

Conversation

lookacat commented Aug 31, 2021 • edited Loading

Description

Types of changes

Checklist:

update-docs bot commented Aug 31, 2021

ownclouders commented Aug 31, 2021

ownclouders commented Sep 1, 2021

ownclouders commented Sep 1, 2021

ownclouders commented Sep 1, 2021

pascalwengerter commented Sep 2, 2021 • edited Loading

pascalwengerter Sep 3, 2021

Choose a reason for hiding this comment

lookacat Sep 6, 2021

Choose a reason for hiding this comment

kulmann left a comment

Choose a reason for hiding this comment

kulmann Sep 6, 2021

Choose a reason for hiding this comment

lookacat Sep 6, 2021

Choose a reason for hiding this comment

kulmann Sep 7, 2021

Choose a reason for hiding this comment

ownclouders commented Sep 7, 2021

ownclouders commented Sep 7, 2021

kulmann left a comment

Choose a reason for hiding this comment

pascalwengerter commented Sep 7, 2021

ownclouders commented Sep 7, 2021

sonarqubecloud bot commented Sep 7, 2021

lookacat commented Aug 31, 2021 •

edited

Loading

pascalwengerter commented Sep 2, 2021 •

edited

Loading